Fix incorrect flattening behavior for hidden nodes#3759
Draft
JustJ01 wants to merge 5 commits intoGraphiteEditor:masterfrom
Draft
Fix incorrect flattening behavior for hidden nodes#3759JustJ01 wants to merge 5 commits intoGraphiteEditor:masterfrom
JustJ01 wants to merge 5 commits intoGraphiteEditor:masterfrom
Conversation
adamgerhant
requested changes
Feb 14, 2026
editor/src/messages/portfolio/document/utility_types/network_interface/resolved_types.rs
Outdated
Show resolved
Hide resolved
|
|
||
| #[derive(Clone, Debug, PartialEq, Hash, serde::Serialize, serde::Deserialize)] | ||
| pub enum Visible { | ||
| Passthrough, |
Collaborator
There was a problem hiding this comment.
Passthrough means to use the current hiding logic, where it is replaced with a Passthrough node
| }; | ||
| let Some(node) = network.nodes.get_mut(node_id) else { | ||
| log::error!("Could not get node {node_id} in set_visibility"); | ||
| if is_visible { |
Collaborator
There was a problem hiding this comment.
This logic is generally wrong. For nodes with no inputs, we want to use the downstream traversal and type lookup solution. For nodes with any number of inputs they just become pass through nodes as is the current behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3629
When a node like Instance Position or Pointer Position is hidden, the flattening logic incorrectly replaces it with a default
()value.This causes:
ConvertNode<DVec2>)Cannot construct default value for hidden nodeentered unreachable code: tried to resolve not flattened nodeExpected Behavior
Hiding a node should:
()unless the node’s real output type is()Solution
Screen.Recording.2026-02-14.021205.mp4
Updated
flatten_with_fnshandling forVisible::Value(output_type).New behavior:
If a compatible input exists
If no compatible input exists
Prevent incorrect
()propagation()unless the node’s actual output type is unit.Result
Instance Positionno longer crashes.ConvertNode<DVec2>no longer receives().